Opened 4 years ago
Last modified 4 years ago
#32098 closed Cleanup/optimization
Made FieldFile use FileField.attname — at Version 2
| Reported by: | Sultan | Owned by: | Sultan |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
In ticket #31701, I suggested making FileDescriptor a subclass of DeferredAttribute and using FileField.attname to access the field data, leaving FileField.name so that users can freely and easily create their own custom subclasses that can not only save data to files, but also represent the same data with a different data type by attaching FileFiled.name to a particular descriptor (just as it is implemented in the models.ForeignKey).
In the patch attached to ticket #31701, I fixed FileField, ImageField and their descriptors, but missed the FieldFile, which still uses FileField.name when saving/deleting a file. I checked everything and made the necessary changes (2 lines).
Change History (2)
comment:1 by , 4 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 4 years ago
| Description: | modified (diff) |
|---|
Note:
See TracTickets
for help on using tickets.