Opened 4 years ago

Last modified 13 months ago

#31949 closed New feature

ASGI - Cache Middleware and some view decorators broken — at Version 1

Reported by: Michael Galler Owned by: nobody
Component: Core (Other) Version: 3.1
Severity: Normal Keywords: async
Cc: Andrew Godwin, Ben Lomax, Roy Smith, Jon Janzen Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Michael Galler)

The cache middleware is broken because it inherits from MiddlewareMixin and override the init method.

TypeError: object HttpResponse can't be used in 'await' expression

On both middlewares the self._async_check() is missing in init.

Also the most view decorators are broken on async views, because the dont provide async/await.

For example:

cache_control
xframe_options_deny
vary_on_cookie

Change History (1)

comment:1 by Michael Galler, 4 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.
Back to Top