Changes between Initial Version and Version 4 of Ticket #31311


Ignore:
Timestamp:
Feb 27, 2020, 8:02:43 AM (5 years ago)
Author:
Kimball Leavitt
Comment:

Thanks for the review. I submitted a PR for this yesterday - ​https://github.com/django/django/pull/12498/files.

You're right, the third one was wrong. I made the fix first, then submitted the ticket, so I hastily grabbed the wrong line. I changed it so it's correct (​https://github.com/django/django/blob/master/django/core/validators.py#L166).

Ah, you beat me to it lol.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #31311

    • Property Triage Stage Unreviewed → Accepted

  • Ticket #31311 – Description

    initial v4  
    33- https://github.com/django/django/blob/master/django/core/validators.py#L68
    44- https://github.com/django/django/blob/master/django/core/validators.py#L85
    5 - https://github.com/django/django/blob/master/django/core/validators.py#L162
     5- https://github.com/django/django/blob/master/django/core/validators.py#L166
Back to Top