Changes between Initial Version and Version 1 of Ticket #30807, comment 4


Ignore:
Timestamp:
Sep 29, 2019, 5:51:21 PM (5 years ago)
Author:
Ad Timmering

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #30807, comment 4

    initial v1  
    11Having now read back the history of the previous tickets (#26494 and #27628) a few thoughts:
    22
    3 `_copy_permissions` was introduced in #27628 to ensure files remain readable by the owner so that files extracted from an archive remain readable (and thus executable), even if they do not have those permissions set within the archive.
     3`_copy_permissions` was introduced in #27628 to ensure files remain readable by the other so that files extracted from an archive remain readable (and thus executable), even if they do not have those permissions set within the archive.
    44
    55It seems we have (at least) two options:
    66
    7 1. Rather than checking it has owner-read (`stat.S_IROTH`) we could do a bit-wise OR to ensure owner-read on all extracted files
     71. Rather than checking it has other-read (`stat.S_IROTH`) we could do a bit-wise OR with owner-read to ensure owner-read on all extracted files
    88 (which is what is happening now too, but in current state group & world permissions are now set to OS default instead of what is set in the archive)
    99
Back to Top