Changes between Initial Version and Version 1 of Ticket #30171, comment 6
- Timestamp:
- Feb 3, 2021, 11:11:22 PM (4 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #30171, comment 6
initial v1 4 4 https://github.com/django/django/commit/37cc6a9dce3354cd37f23ee972bc25b0e5cebd5c 5 5 6 For example, was it intentional that this SQLite-specific condition (`if conn.vendor == 'sqlite' and conn.is_in_memory_db():`) was removed from `_tearDownClassInternal()`, even though it's still in `setUpClass()`? 6 For example, was it intentional that this SQLite-specific condition (`if conn.vendor == 'sqlite' and conn.is_in_memory_db():`) was removed from `_tearDownClassInternal()`, even though it's still in `setUpClass()`? Line here: 7 https://github.com/django/django/commit/37cc6a9dce3354cd37f23ee972bc25b0e5cebd5c#diff-7833da5b45a68d00834388d97dd5c4413e3796497c7bc5e0cc2621b08a2d0df1L1483 7 8 8 Also, for reasons of symmetry with `setUpClass()`, it doesn't seem like those connection restore lines should have been moved beneath the `if hasattr(cls, 'server_thread'):` condition . Basically, it looks like a couple lines were deleted, perhaps by accident.9 Also, for reasons of symmetry with `setUpClass()`, it doesn't seem like those connection restore lines should have been moved beneath the `if hasattr(cls, 'server_thread'):` condition in `_tearDownClassInternal()`. Basically, it looks like a couple lines were deleted, perhaps by accident.