Changes between Initial Version and Version 1 of Ticket #30083, comment 4


Ignore:
Timestamp:
Feb 19, 2019, 11:09:49 PM (6 years ago)
Author:
Simon Charette

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #30083, comment 4

    initial v1  
    1 I left comments for improvements on the PR. After a read through of #18532 I'm still not convinced the addition in complexity is worth it. I never add to use init signals though but performing queries in receivers seems like a recipe for disaster.
     1I left comments for improvements on the PR. After a read through of #18532 I'm still not convinced the addition in complexity is worth it. I never add to use init signals though but performing queries in receivers of such signals seems like a recipe for disaster.
    22
    33The suggested implementation will also have the side effect of exposing instances with a `._state` attribute in `pre_init` signal while it wasn't the case before. If we wanted to maintain backward compatibility it could be fired from `Model.__new__` through which is probably where it should belong in the first place.
Back to Top