Changes between Version 1 and Version 2 of Ticket #30064, comment 10
- Timestamp:
- Jan 25, 2019, 9:13:17 AM (6 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #30064, comment 10
v1 v2 1 Hello Can, it does look more appropriate. The page field should probably be a `forms.IntegerField` and you shouldn't have to perform any form of manual check for `'\x00'` as `forms.CharField` already has a `ProhibitNullCharactersValidator`. We'll have to find a way to surface the exception appropriately because raising it at `ChangeList` initialization will just result in a different crash. 1 Hello Can, it does look more appropriate. The page field should probably be a `forms.IntegerField` and you shouldn't have to perform any form of manual check for `'\x00'` as `forms.CharField` already has a `ProhibitNullCharactersValidator`. We'll have to find a way to surface the exception appropriately because raising it at `ChangeList` initialization will just result in a different crash. Please submit your work as a PR so it's easier to review.