Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#29662 closed Cleanup/optimization (fixed)

Test client should accept json types with structured suffixes

Reported by: Marnanel Thurman Owned by: Zach Bresser
Component: Testing framework Version: 2.1
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Ramiro Morales)

The test client's json() method should permit the Content-Type of the response to contain structured suffixes, such as "application/activity+json".

This requires a regexp such as "^application\/(.+\+)?json".

See RFC 6838 for the specification: ​https://tools.ietf.org/html/rfc6838#section-4.2.8
An example in the official registry: ​https://www.iana.org/assignments/media-types/application/activity+json

Issue #27622 provided a partial fix but allowed only vendor-specific prefixes.

Change History (9)

comment:1 by Claude Paroz, 6 years ago

Has patch: set
Needs tests: set
Triage Stage: Unreviewed → Accepted
Type: Bug → Cleanup/optimization

comment:2 by Ramiro Morales, 6 years ago

Description: modified (diff)

comment:3 by Zach Bresser, 6 years ago

Owner: changed from nobody to Zach Bresser
Status: new → assigned

If my understanding is correct it should just be the following changes:

Changing JSON_CONTENT_TYPE_RE = re.compile(r'^application\/(vnd\..+\+)?json') to JSON_CONTENT_TYPE_RE = re.compile(r'^application\/(.+\+)?json' in django.test.client

As well as adding some tests. I can take this as my first PR.

comment:4 by Simon Charette, 6 years ago

Zach thanks for offering but it looks like there's already a PR that wasn't linked to this ticket

​https://github.com/django/django/pull/10288

Version 0, edited 6 years ago by Simon Charette (next)

comment:5 by Claude Paroz, 6 years ago

Needs tests: unset

comment:6 by Zach Bresser, 6 years ago

Needs tests: set

​PR

comment:7 by Zach Bresser, 6 years ago

Needs tests: unset

I'm sorry Simon, I didn't realize. I have put in a PR, we make the same changes except I added a note in the Docs too. What is the next step? Close/Merge?

comment:8 by Tim Graham <timograham@…>, 6 years ago

Resolution: → fixed
Status: assigned → closed

In 7cc5225:

Fixed #29662 -- Allowed test client to accept structured suffix JSON content types.

comment:9 by Tim Graham <timograham@…>, 6 years ago

In ef30633:

[2.1.x] Fixed #29662 -- Allowed test client to accept structured suffix JSON content types.

Backport of 7cc52250f06c2a4769badbab1d7ee01f8e3cb46a from master

Note: See TracTickets for help on using tickets.
Back to Top