Changes between Initial Version and Version 1 of Ticket #29505, comment 3


Ignore:
Timestamp:
Nov 16, 2018, 2:05:01 PM (6 years ago)
Author:
Tim Graham

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #29505, comment 3

    initial v1  
    1 I believe the proposed patch would break callable defaults. In `effective_defautl()`, `field.get_default()` may return a callable and `Field.get_prep_value()` won't work properly if it receives a callable instead of a value. I guess test coverage is lacking.
     1I believe the proposed patch would break callable defaults. In `effective_default()`, `field.get_default()` may return a callable and `Field.get_prep_value()` won't work properly if it receives a callable instead of a value. I guess test coverage is lacking.
    22
    33I think you should change your `__call__()` method to make `other` an optional argument.
Back to Top