Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#28747 closed Cleanup/optimization (fixed)

Unclosed single quotes in django/conf/global_settings.py comments

Reported by: Oleksandr Owned by: Duarte Fernandes
Component: Core (Other) Version: 1.11
Severity: Normal Keywords: Comment, typo
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

In file: django/conf/global_settings.py
In lines 251-253 there are an example with list of compiled RegExps.
Three of them contain unclosed quotes.
Here is the code:

#    IGNORABLE_404_URLS = [
#        re.compile(r'^/apple-touch-icon.*\.png$'),
#        re.compile(r'^/favicon.ico$),
#        re.compile(r'^/robots.txt$),
#        re.compile(r'^/phpmyadmin/),
#        re.compile(r'\.(cgi|php|pl)$'),
#    ]

Change History (7)

comment:1 by Duarte Fernandes, 7 years ago

Owner: changed from nobody to Duarte Fernandes
Status: newassigned

comment:2 by Duarte Fernandes, 7 years ago

Just submitted a PR to django:stable/1.11.x, as this ticket has 1.11 for its version. Please let me know if I should apply these changes to the master as well.

Final work:

#        re.compile(r'^/favicon.ico$),
#        re.compile(r'^/robots.txt$),
#        re.compile(r'^/phpmyadmin/),
Version 0, edited 7 years ago by Duarte Fernandes (next)

comment:3 by Duarte Fernandes, 7 years ago

Has patch: set
Last edited 7 years ago by Duarte Fernandes (previous) (diff)

comment:4 by Tim Graham, 7 years ago

Component: UncategorizedCore (Other)
Summary: Unclosed single quotes in exampleUnclosed single quotes in django/conf/global_settings.py comments
Triage Stage: UnreviewedReady for checkin

comment:5 by Tim Graham <timograham@…>, 7 years ago

Resolution: fixed
Status: assignedclosed

In 019c260:

Fixed #28747 -- Fixed typos in django/conf/global_settings.py comments.

comment:6 by Tim Graham <timograham@…>, 7 years ago

In ecfa7e5:

[2.0.x] Fixed #28747 -- Fixed typos in django/conf/global_settings.py comments.

Backport of 019c2600a6771d2cd0574062dee468ce96d7e69d from master

comment:7 by Tim Graham <timograham@…>, 7 years ago

In 8038b5c:

[1.11.x] Fixed #28747 -- Fixed typos in django/conf/global_settings.py comments.

Backport of 019c2600a6771d2cd0574062dee468ce96d7e69d from master

Note: See TracTickets for help on using tickets.
Back to Top