Changes between Initial Version and Version 1 of Ticket #28602, comment 3


Ignore:
Timestamp:
Sep 29, 2017, 9:39:44 AM (7 years ago)
Author:
Tom Forbes

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28602, comment 3

    initial v1  
    22
    33I've got a PR in that ticket (https://github.com/django/django/pull/8819) to refactor the autoreloader and add support for the Watchdog library (and watchman) over pyinotify, which handles the intricacies of Windows, Linux and Mac file system notifications. IMO, after reading the Watchdog code and seeing the rather tricky corner cases it handles (e.g [[https://github.com/gorakhargosh/watchdog/blob/f1d32fd0e02cfbc727ae2b15f6eb9937959c3541/src/watchdog/observers/read_directory_changes.py#L85-L104|this]]) it would be best to outsource it there than maintain our own.
     4
     5Perhaps we could split #27685 into two parts, one to add support for Windows/Mac/Linux FS notifications via Watchdog (this ticket) and one to expand it to support Watchman?
Back to Top