Opened 7 years ago
Last modified 8 months ago
#28369 new New feature
Provide ModelAdmin hooks for reversing URLs
Reported by: | steve yeago | Owned by: | nobody |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Christophe Baldy, Ülgen Sarıkavak | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | yes |
Needs tests: | yes | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Django admin could provide a hook for cases where there are additional parameters necessary to build an add or change url. Current hook "response_change" makes many hard-coded presumptions about how to reverse and add or change url. While its a nice hook to have for some cases, its so verbose that overriding it for this purpose is very hard.
Change History (8)
comment:2 by , 7 years ago
Easy pickings: | unset |
---|---|
Needs documentation: | set |
Needs tests: | set |
Summary: | Django Admin "Save and add another" NoReverseMatch with custom urls → Provide ModelAdmin hooks for reversing URLs |
I lamented on django-developers about the never ending number of ModelAdmin
hooks. I fear we'll end up with an unmaintainable mess if we make every little thing customizable. Those methods would also need to be documented and tested. Perhaps you could describe your use case in more detail to help justify the additional complexity.
comment:3 by , 7 years ago
Well in some ways I think the patch creates some consistency given that there is already a hook for the "view on site" url in the admin. Grepping around, there could be some savings of lines get_*_url in the tests where basically the same hooks already exists.
Example: http://dpaste.com/1JFCGQG
The current implementation presumes that a modeladmin is registered under a namespace with no other args or kwargs, but that may not be the case if someone has included additional url args in get_urls(). Almost everything about the admin works fine out of the box in this situation aside from the somewhat superficial problem of where the user is redirect post-save because, the urls that are being reversed deep in response_change (and subsequently response_post_save_change) are hard-coded.
comment:4 by , 7 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:6 by , 7 years ago
The patch still lacks documentation of the new ModelAdmin
methods (see the PatchReviewChecklist). You should update the ticket's flags as indicated in the "According to the ticket's flags, the next step(s) to move this issue forward are:" box below the ticket description.
comment:7 by , 6 years ago
Cc: | added |
---|
comment:8 by , 8 months ago
Cc: | added |
---|
PR