Changes between Initial Version and Version 2 of Ticket #28082


Ignore:
Timestamp:
Apr 20, 2017, 6:25:45 PM (7 years ago)
Author:
Leon Matthews
Comment:

Linked to pull request as requested.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #28082

    • Property Has patch set
    • Property Needs tests set
    • Property Triage Stage Unreviewed → Accepted
    • Property Summary Pull request #8364: BaseDateListView should pass all context to subclasses → BaseDateListView should pass all context to subclasses

  • Ticket #28082 – Description

    initial v2  
    33BaseDateListView.get() currently modifies the context after calling get_context_data(), which prevents users from access those data in their base classes. I ran into this suprising quirk when I wanted to access the current month in my MonthArchiveView subclass's get_context_data().
    44
    5 I have created a GitHub pull request https://github.com/django/django/pull/8364
     5I have created a [https://github.com/django/django/pull/8364 pull request] for a very minimal patch.
    66
    77(To really tidy things up, we could have all instances get_dated_items() return a single dictionary that we pass to get_context_data as kwargs, but I am a realist on occasion...)
Back to Top