Changes between Version 4 and Version 5 of Ticket #27647


Ignore:
Timestamp:
Dec 27, 2016, 10:22:39 AM (8 years ago)
Author:
Aleksi Häkli
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #27647 – Description

    v4 v5  
    33The problem is apparently on this line:
    44
    5 https://github.com/django/django/blob/b79fc11d730b5beff92e9dd8853a61524cdeffe3/django/utils/autoreload.py#L290
     5[https://github.com/django/django/blob/b79fc11d730b5beff92e9dd8853a61524cdeffe3/django/utils/autoreload.py#L290]
    66
    77Python documentation states that the ''`os.spawnve` function is NOT thread-safe on Windows'' and that the `subprocess` module should be used instead.
     
    1111I propose that `autoreload.py` be refactored to use a thread-safe implementation either by the subprocess module or by other alternative implementation.
    1212
    13 **Update**: I added a preliminary patch implementation up for review that implements a fix for Python 2.4+ in [https://github.com/django/djangopull/7748]  by using the recommended `subprocess.call()` instead of the non-thread-safe `os.spawnve()` which was added in 2005.
     13**Update**: I added a preliminary patch implementation up for review that implements a fix for Python 2.4+ in [https://github.com/django/django/pull/7748]  by using the recommended `subprocess.call()` instead of the non-thread-safe `os.spawnve()` which was added in a commit in 2005.
    1414
    1515----
Back to Top