#27318 closed Cleanup/optimization (fixed)
Return failed values from memcached.set_many()
| Reported by: | Florent Fourcot | Owned by: | Olivier Tabone |
|---|---|---|---|
| Component: | Core (Cache system) | Version: | 1.10 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The set_many method of MemcachedBackend does not return anything, even if both python-memcached and pylibmc libraries return the list of failing keys.
As result, the backend can fail silently.
Attachments (1)
Change History (11)
by , 8 years ago
| Attachment: | 0001-Fixed-27318-Return-list-of-failing-keys-with-set_man.patch added |
|---|
comment:1 by , 8 years ago
| Needs tests: | set |
|---|---|
| Summary: | No return of failed values with memcached.set_many() → Return failed values from memcached.set_many() |
| Triage Stage: | Unreviewed → Accepted |
| Type: | Bug → Cleanup/optimization |
comment:2 by , 8 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
claim the ticket during duth sprints, created a new PR (the other one was just a one liner).
please review the pr.
Added tests, as recommended in the original PR review.
updated the docs
comment:3 by , 8 years ago
| Needs tests: | unset |
|---|---|
| Patch needs improvement: | set |
I left comments for improvement on the PR.
comment:4 by , 8 years ago
| Patch needs improvement: | unset |
|---|
updated the PR, please feel free to review and comment.
comment:6 by , 8 years ago
| Patch needs improvement: | set |
|---|
comment:7 by , 7 years ago
| Patch needs improvement: | unset |
|---|
Note:
See TracTickets
for help on using tickets.
As noted on the PR, tests are needed.