Opened 9 years ago

Last modified 9 years ago

#26460 closed Cleanup/optimization

Don't call ``warnings.warn`` for each invalid character in a caching key — at Version 1

Reported by: Przemysław Suliga Owned by: nobody
Component: Core (Cache system) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Przemysław Suliga)

BaseCache.validate_key() will call warnings.warn() ​for each invalid character in the key. This is not a big issue since only one warning will appear but it is unnecessary.

Fixed in ​https://github.com/django/django/pull/6414

Change History (1)

comment:1 by Przemysław Suliga, 9 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.
Back to Top