Changes between Initial Version and Version 1 of Ticket #26315, comment 5


Ignore:
Timestamp:
Sep 30, 2016, 5:38:15 AM (8 years ago)
Author:
Melvyn Sopacua

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #26315, comment 5

    initial v1  
    2323This means those commands blow up on `options['no_color']` with a `KeyError`. When the exception is caught and reformatted things get worse, like [https://bitbucket.org/stephenmcd/mezzanine/src/82939507b6dc2519161db6ee49fec1bd194520de/mezzanine/utils/docs.py?at=default&fileviewer=file-view-default#docs.py-259 here], where the resulting error message (Couldn't build model_graph, graph_models failed on: 'no_color') made me think of lacking LCMS support in Pillow.
    2424
    25 I'm proposing a temporary fix to check if all "options created by argparse" - in fact being the options that should always be supported on any management command are in fact present in the passed in options dict and if not issue a `DeprecationWarning` that calling call_command() without passing the original options dictionary will be unsupported in the future.
     25I'm proposing a temporary fix to check if all "options created by argparse" - being the options that should always be supported on any management command are in fact present in the passed in options dict and if not issue a `DeprecationWarning` that calling call_command() without passing the original options dictionary will be unsupported in the future.
Back to Top