#26205 closed Uncategorized (needsinfo)
migrate and other commands fail with TypeError: 'NoneType' object has no attribute '__getitem__' in schema.py
Reported by: | D | Owned by: | nobody |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | 1.9 |
Severity: | Normal | Keywords: | schema.py PRAGMA NonType migrate |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Only occurs with a sqlite engine where the command "PRAGMA foreign_keys" returns nothing (instead of returning 0 or 1).
This happens (at least) on sqlite3 v 3.3.6. Doesn't occur on 3.8.11.
The net effect is that the following manage.py comands fail;
migrate
makemigrations
test
plus other commands if they trigger a migration.
Changing line 25 of django/db/backends/sqlite3/schema.py from this;
self._initial_pragma_fk = c.fetchone()[0]
to this
self._initial_pragma_fk = 0 # c.fetchone()[0]
enables you to proceed with the migration.
Change History (6)
comment:1 by , 9 years ago
comment:2 by , 9 years ago
Regarding not supporting 3.3.6, that's fair enough, but for anyone following even the most basic getting-started tutorials, the exception this throws is way beyond what a beginner should be expected to troubleshoot. Even knowing that it might be a back-end issue, or finding your version of sqlite3 is not obvious from the exception.
My server (smeserver 8.2/centos 5.11) had been running django (various versions) for about 2 years fine until I upgraded to django 1.9.2 and nuked the db and tried to run migrations from scratch. I didn't even have sqlite3 installed, but So I had to install sqlite3 to even find the version number of sqlite3.
How about wrapping line 25 in a try: block to ensure a value is returned from "PRAGMA foreign_keys", or testing the sqlite version like other backends do (AFAIK) so that a helpful error message can be thrown (rather than ...NoneType' object has no attribute...)?
comment:3 by , 9 years ago
Django uses pysqlite2 if it is installed, but most often it falls back to the sqlite3 integrated module.
On Python 2.7:
$ python2 Python 2.7.9 (default, Mar 1 2015, 12:57:24) [GCC 4.9.2] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import sqlite3 >>> sqlite3.sqlite_version '3.8.7.1'
follow-up: 6 comment:4 by , 9 years ago
Where do you encounter this old version of SQLite? Django only supports the latest point release of each major version of Python, so if this is with an older point release, I don't think additional documentation is necessary.
comment:5 by , 9 years ago
Component: | Uncategorized → Database layer (models, ORM) |
---|---|
Resolution: | → needsinfo |
Status: | new → closed |
comment:6 by , 8 years ago
Replying to timgraham:
Where do you encounter this old version of SQLite? Django only supports the latest point release of each major version of Python, so if this is with an older point release, I don't think additional documentation is necessary.
Tim: This occurs on SME 8.1, which is based on CentOS 5.10
https://wiki.contribs.org/SME_Server:8.1
These packages are currently available in the standard repo:
python-sqlite-1.1.7-1.2.1.0 sqlite-3.3.6-7 sqlite-devel-3.3.6-7
While we don't document a minimum sqlite3 version I don't think we should commit to support a version that is almost 10 years old.
I suggest we document a minimal supported version like we do with other backends.