Opened 9 years ago

Last modified 9 years ago

#26204 closed Bug

URLValidator does not accept TLDs with "-"s — at Version 2

Reported by: Luke Faraone Owned by: nobody
Component: Core (Other) Version: 1.8
Severity: Normal Keywords: regression
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Luke Faraone)

Forwarded from:
http://bugs.debian.org/814372

Previous versions of Django allowed for "-"s in the rightmost component of a hostname. This was tightened in a previous release. While the case for punycode domains was fixed, there's no technical reason to disallow them in any part of a hostname component except for at the beginning or end.

That is to say: http://ubuntu-mirror.my-tld/ubuntu is flagged as an invalid URL, even though the DNS has an IP for it, and apt happily upgrades from the archive mirror that is there.

The fix for <https://code.djangoproject.com/ticket/25452#comment:2> appears to be when this regression was introduced.

Change History (2)

comment:1 by Luke Faraone, 9 years ago

Description: modified (diff)

comment:2 by Luke Faraone, 9 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.
Back to Top