Changes between Initial Version and Version 3 of Ticket #26079


Ignore:
Timestamp:
Jan 13, 2016, 6:36:44 AM (9 years ago)
Author:
Tim Graham
Comment:

I'm not immediately convinced that a database field is the way to go for a couple reasons:

  1. It would make data less portable between development (where SSL is often not in use) and production.
  2. I'm not sure it's a common case that only some sites would use SSL but not others.

A third-party library called django-hosts, which djangoproject.com uses, adds a setting called ​HOSTS_SCHEME to solve this. I think there's been some discussion about merging at least parts of this library into core since it solves common problems.

See also #10944 (we might close this ticket as a duplicate of that one) and #23829 (about customizing ping_google to allow https). I think the best course of action would be to consider this feedback and write to the DevelopersMailingList with your proposal. Either solution of a new setting or a new database field need feedback from a wider audience. Thanks!

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #26079

    • Property Owner changed from nobody to Eric
    • Property Status new → assigned
    • Property Patch needs improvement set
    • Property Needs tests set

  • Ticket #26079 – Description

    initial v3  
    1 I think adding a prefered/default protocol in the sites framework would be a great addition for generating full url's to django websites. 
     1I think adding a preferred/default protocol in the sites framework would be a great addition for generating full url's to django websites. 
    22
    33specially when generating url from action not coming from a request like the sitemaps [https://github.com/django/django/blob/master/django/contrib/sitemaps/__init__.py#L42 ping_google] that assumes the protocol to be http:
Back to Top