Fix RuntimeWarnings about model reloading in test suite

[Tim Graham]

Similar warnings to those reported in #24812 are back in several apps: order_with_respect_to, foreign_object, schema.

To see the order_with_respect_to warnings, you must also include contenttypes_tests (these apps share models):
$ python -Wall runtests.py order_with_respect_to contenttypes_tests

Example:

/home/tim/code/django/django/db/models/base.py:283: RuntimeWarning: Model 'order_with_respect_to.bar' was already registered. Reloading models is not advised as it can lead to inconsistencies, most notably with related models.

We should probably promote RuntimeWarning to "error" in tests/runtests.py to prevent future regressions.

[Simon Charette]

I wonder if the order_with_respect_to and foreign_object issues are fixed by the following commits:

​https://github.com/charettes/django/commit/836c19a2b64e8324fa792104fddb434e29be125c
​https://github.com/charettes/django/commit/8eb98a0809229e635d1603c19314ac4c383d9ead

which are part of this ​PR.

[Simon Charette]

I confirm that the issues are fixed by the proposed commits.

[Simon Charette]

The schema tests will need a bit of adjustment to avoid registering the LocalTagThrough model multiple time to the same apps instance (see SchemaTests._test_m2m_create_through).

[Simon Charette]

Tim what do you think of closing this ticket in favor of #25746?

Maybe we should reuse this one for the sole purpose of promoting RuntimeError to errors?

[Tim Graham]

I'd appreciate (perhaps simpler) patches we could backport to 1.9 and 1.8 (schema only).

[Simon Charette]

​PR

[Simon Charette <charette.s@…>]

In 406de4c:

Refs #25745 -- Isolated an order_with_respect_to test.

[Simon Charette <charette.s@…>]

In 2eefbca:

Refs #25745 -- Isolated a foreign_object test.

[Simon Charette <charette.s@…>]

In 64240263:

Refs #25745 -- Avoided multiple registration of the same model in schema tests.

[Simon Charette <charette.s@…>]

In d95b22b:

Refs #25745 -- Isolated some postgres array field check tests.

[Simon Charette <charette.s@…>]

In 1c5f4e86:

Fixed #25745 -- Promoted RuntimeWarnings to errors in the test suite.

[Simon Charette <charette.s@…>]

In e8512811:

[1.9.x] Refs #25745 -- Isolated an order_with_respect_to test.

Backport of 406de4c243e3618c13c36c23e07a4aa33162b344 from master

[Simon Charette <charette.s@…>]

In fb016e6:

[1.9.x] Refs #25745 -- Isolated a foreign_object test.

Backport of 2eefbca1a4140d8a8174a06a1f0160fcc76d8f64 from master

[Simon Charette <charette.s@…>]

In 77e5790:

[1.9.x] Refs #25745 -- Avoided multiple registration of the same model in schema tests.

Backport of 64240263f22055cb539159e9359e64d5096f39d9 from master

[Simon Charette <charette.s@…>]

In cfa3d4a2:

[1.9.x] Refs #25745 -- Isolated some postgres array field check tests.

Backport of d95b22bd56764c71047ec16f628c00c0fd997cfd from master

[Simon Charette <charette.s@…>]

In ef78aec2:

[1.9.x] Fixed #25745 -- Promoted RuntimeWarnings to errors in the test suite.

Backport of 1c5f4e86bc9c7bae5d5f3830d9cfbb0043297261 from master

[Simon Charette <charette.s@…>]

In afe84c71:

[1.8.x] Refs #25745 -- Avoided multiple registration of the same model in schema tests.

Conflicts:

tests/schema/tests.py

Backport of 64240263f22055cb539159e9359e64d5096f39d9 from master

[Simon Charette <charette.s@…>]

In 5a6a5ce0:

[1.8.x] Fixed #25745 -- Promoted RuntimeWarnings to errors in the test suite.

Conflicts:

tests/apps/tests.py
tests/migrations/test_graph.py
tests/queryset_pickle/tests.py
tests/runtests.py

Backport of 1c5f4e86bc9c7bae5d5f3830d9cfbb0043297261 from master