Make 'request' available to syndication.Feed methods

[Ramez Issac]

Use case : adding an image to feed.
i will to override Feed.item_extra_kwargs() and get my image url, But i can't make a Full URL as i'm missing the request.host

Proposal:
Add request to Feed class so it's accessible via self.request (as CBV)

[Tim Graham]

Looks like an okay idea at first glance.

[Alex Morozov]

I believe this will require functionality similar to View.as_view() to be thread-safe. Or even sublassing the Feed from the generic View. But this apparently will break backwards compatibility.

@timgraham, what do you think about it? Is it worth bothering?

[Ramez Issac]

Either add it to the Feed class in Feed.__call__() , or later on in Feed.get_feed()
If that is not convenient for some reason (@alexmorozov care to elaborate on thread safe part, How this wont be thread safe?! I'm not an expert in this area)

The next best thing is to send it as a parameter but this road is long, bumpy and not backward compatible.

[Ramez Issac]

Replying to alexmorozov:

I believe this will require functionality similar to View.as_view() to be thread-safe. Or even sublassing the Feed from the generic View. But this apparently will break backwards compatibility.

Can we implement as_view() code in the __call__() behind the scenes and escape backward-incompatibility ?!

[Alex Morozov]

@RamezIssac: I surely can implement it either as a as_view() addition or a __call__() override. The problem is, AFAIK, Django is very conservative when it comes to breaking compatibility (it seems to me, the __call()__ override will break it too).

So I'd like to get an approvement from core devs before I start, so that my work won't be ultimately dumped.
I you ask me, I believe we should subclass the generic.View.

[Alex Morozov]

Clearing the 'Easy pickings' flag, as it is obviously not the case.