Allow method_decorator() to accept a list/tuple of decorators

[zauddelig]

Hello,
The new method decorator allow to decorate a class directly. to augment its readability I would propose to let it accept an iterable of decorator functions.

This could be useful because it's common to decorate views using redundant sets of decorators inside the same project or subproject, one could argue that the same result is attained creating a new decorator or a Mixin, yet an iterable, i. e. a tuple, seem to me more plastic and maintainable than a class or a function.

This could be also useful if one intend to dynamically decorate dynamically created classes although this is most probably going to be useful in less than the 1% of the cases, so actually not significant.

The proposal introduces a polymorphic behaviour to method_decorator which should now accept both function and iterables, so both the following examples should be valid:

decorators = (
    blacklist_ip,
    request_is_cool,
    login_required,
)

@method_decorator(decorators,"dispatch")
class ProtectedView(View):
    # lot of meaningful code
    pass

@method_decorator(login_required, "dispatch")
class LessProtectedView(View):
    # lot of meaningful code
    pass

pull request: ​https://github.com/django/django/pull/5136

[zauddelig]

I updated the pull requested:

​https://github.com/django/django/pull/5134

It was added some documentation to the new behavior pretty much mimicking the excellent one already done by zedr.

I will squash when the PR is accepted and before it is merged if that is not a problem.

[zauddelig]

I have done one big mess up while rebasing I closed the PR and Opened another

[Tim Graham]

A few more updates are required but this seems to be in mostly good shape.

[Tim Graham]

I'm updating the patch.

[Tim Graham]

​Updated PR

[Berker Peksag]

​PR #5311 LGTM.

[Tim Graham <timograham@…>]

In 186eb21d:

Fixed #25269 -- Allowed method_decorator() to accept a list/tuple of decorators.

[Chris Jerdonek]

FYI, I filed ticket #29253 about the implementation of this feature.