Changes between Version 1 and Version 2 of Ticket #25187, comment 12
- Timestamp:
- Feb 22, 2017, 1:57:37 AM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #25187, comment 12
v1 v2 1 Testing on 1.11b1, this change breaks code like django-cas-ng that provided their own view to pass the `request` keyword argument: https://github.com/mingchen/django-cas-ng/blob/master/django_cas_ng/views.py#L59-L61 1 Testing on 1.11b1, this change breaks code like django-cas-ng that provided their own view to pass `request` as a keyword argument: 2 https://github.com/mingchen/django-cas-ng/blob/master/django_cas_ng/backends.py#L19 (https://github.com/mingchen/django-cas-ng/blob/master/django_cas_ng/views.py#L59-L61) 2 3 3 4 If this can't be fixed in time for 1.11 then the release notes should document clearly that `request` needs to be the first positional argument, not a keyword argument.