Have password_reset pass extra_context to the email template rendering as well

[twelveeighty]

The password_reset function in auth.views currently allows for extra context parameters to be passed to the rendered reset password form, but it does not pass through those extra context parameters to the 'opt' dictionary used for the email template. This should be an easy feature to add: just before the form.save(), add the extra_context to the opts dictionary:

# inside the request.method == 'POST' and form.isValid() block:
opts = {  ...  }
if extra_context is not None:
   opts.update(extra_context)
form.save(**opts)

[Tim Graham]

I guess it's unlikely, but we'd have a small backwards compatibility issue if someone is using extra_context with a key that clashes with one in opts. For that reason, it might be better to use a separate parameter.

There is also the idea of converting these views to class-based views in #17209 which might help here.

[Tim Graham]

A ticket isn't marked fixed until the patch is committed to Django. Also your patch is missing tests and documentation as outlined in our ​patch review checklist. Also your patch has a problem if someone is using extra_context with a key that clashes with one in opts as I mentioned in comment 1.

[Sujay S Kumar]

Replying to timgraham:

A ticket isn't marked fixed until the patch is committed to Django. Also your patch is missing tests and documentation as outlined in our ​patch review checklist. Also your patch has a problem if someone is using extra_context with a key that clashes with one in opts as I mentioned in comment 1.

I am new to contributing to open source. I am not able to understand where to put the documentation for this new feature. I would be grateful if you could point to the file in which I should add the documentation.

[Tim Graham]

The password reset function is documented in docs/topics/auth/default.txt.

[Berker Peksag]

Left some trivial review comments. Tim also reviewed the pull request yesterday.

[Tim Graham <timograham@…>]

In d8d85337:

Fixed #24944 -- Added extra_email_context parameter to password_reset() view.

[Mariusz Felisiak <felisiak.mariusz@…>]

In aff61790:

Refs #24944 -- Added test for overriding domain in email context in PasswordResetView.