Changes between Initial Version and Version 1 of Ticket #24929


Ignore:
Timestamp:
Jun 5, 2015, 3:08:59 AM (9 years ago)
Author:
Raphael Michel
Comment:

I created the pull request: ​https://github.com/django/django/pull/4790

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #24929

    • Property Has patch set
    • Property Owner set to Raphael Michel
    • Property Status new → assigned
    • Property Summary permission_required decorator should take any iterable if permissions → permission_required decorator should take any iterable of permissions

  • Ticket #24929 – Description

    initial v1  
    1 As it came up in the discussion on ticket #24914 on GitHub (https://github.com/django/django/pull/4749#discussion_r31776720), there is no reason why permission_required only takes lists and tuples of permissions, while `has_perm` itself can take any iterable. To be consistent with the new mixins and other parts of Django where boths strings and iterables of strings are accepted (see e.g. model._meta.ordering), we should change this logic. I will prepare a pull request with the same logic that is used in other places.
     1As it came up in the discussion on ticket #24914 on GitHub (https://github.com/django/django/pull/4749#discussion_r31776720), there is no reason why permission_required only takes lists and tuples of permissions, while `has_perms` itself can take any iterable. To be consistent with the new mixins and other parts of Django where both strings and iterables of strings are accepted (see e.g. model._meta.ordering), we should change this logic. I will prepare a pull request with the same logic that is used in other places.
Back to Top