Opened 10 years ago

Last modified 10 years ago

#24676 closed Bug

Regression on ManytoMany — at Initial Version

Reported by: CARRIERE Etienne Owned by: nobody
Component: contrib.admin Version: 1.8
Severity: Release blocker Keywords:
Cc: CARRIERE Etienne Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Hi,

We have discovered a small regression in 1.7 with the ManytoMany representation in admin page :
Configuration to reproduce :

  • Have a many to many Field
  • Put the ManytoMany Field as a filter_horizontal block (I am not sure if it is mandatory)

Behaviour :

  • Before the #13165 ticket commit, below the 'form-row' div, we have a second div (without class) and below this block is directly the different blocks
    • The label
    • The elements for the widget => in the same level as the other elements
    • The help paragraph

With the javascript in SelectFilter2 (in admin/js), the help paragraph is put on the first place of the div block (the one without class)

  • After the #13165, a div block ( 'related-widget-wrapper' ) has been added so that the second div looks like :
    • The label
    • A new div 'related-widget-wrapper'
    • The help paragraph

Proposal to solve
I see 2 methods to solve the bug

  • Don't use the 'related-widget-wrapper' for the ManytoMany as the ticket #13165 was made only for the classical ForeignKey
  • Modify the SelectFilter2 js to adapt to the new block

Change History (0)

Note: See TracTickets for help on using tickets.
Back to Top