Changes between Initial Version and Version 7 of Ticket #24509

Timestamp:

Aug 5, 2015, 4:30:14 AM (9 years ago)

Author:

Alex Hill

Comment:

Here's my patch implementing this: ​https://github.com/django/django/pull/5099

It also adds support for expressions (and placeholders) in bulk inserts.

Notes:

• As Carl suggested, this should allow us to get rid of get_placeholder() entirely.
• The handling of AutoFields is a bit ugly at the moment. If an AutoField's value is None, it's removed from the list of fields in Model._save_table() and then conditionally re-added in SQLInsertCompiler.as_sql(). I'm thinking about nicer ways to handle this.
• There is a heap of same-but-different code between SQLInsertCompiler and SQLUpdateCompiler, especially now that expressions are supported. I'd like to clean this up in a subsequent patch.
• I've changed the workaround for #10888. I'm pretty sure it won't change anything, but I can't test in Oracle.