Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#23585 closed Cleanup/optimization (fixed)

Fix misleading comment in CSRF middleware

Reported by: Aymeric Augustin Owned by: Aymeric Augustin
Component: CSRF Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

See ​https://groups.google.com/d/msg/django-developers/24QVPMg7dsE/bx3qf2YLKyoJ

Change History (4)

comment:1 by Grzegorz Ślusarek, 10 years ago

Easy pickings: set
Has patch: set

here is pr: ​https://github.com/django/django/pull/3526

comment:2 by Berker Peksag, 10 years ago

Triage Stage: Accepted → Ready for checkin

​PR #3526 LGTM.

Last edited 10 years ago by Berker Peksag (previous) (diff)

comment:3 by Grzegorz Slusarek <grzegorz.slusarek@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In b4bb5cd0a31c6e9ebc2be9dff245f506940f9159:

Fixed #23585 - Corrected internal comment.

Removed misleading comment and provide correct one, explaining
idea behind hardcoded CSRF template context processor.

comment:4 by Marc Tamlyn <marc.tamlyn@…>, 10 years ago

In 4024dd0c98d71647b2001f186a92242314c987b2:

Merge pull request #3526 from gregorth/ticket_23585

Fixed #23585 - Corrected internal comment.

Note: See TracTickets for help on using tickets.
Back to Top