Changes between Initial Version and Version 1 of Ticket #22447, comment 8


Ignore:
Timestamp:
Apr 16, 2014, 1:20:26 PM (10 years ago)
Author:
Simon Charette

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #22447, comment 8

    initial v1  
    11It doesn't work in the `mttp` case because they skip `ModelBase.__new__` [https://github.com/django-mptt/django-mptt/blob/master/mptt/models.py#L217-L218 here], it would work if they called `super(MPTTModelBase, cls).__new__` instead.
    22
    3 Unsure how to deal correctly with this. [https://bitbucket.org/gutworth/six/issue/66/replace-the-implementation-of I've proposed] `six` to replace their `with_metaclass` implementation with [https://github.com/mitsuhiko/flask/blob/6ec83e18dca497a8fbfca6caca5999984bd32f2e/flask/_compat.py#L56-L73 the one Flask uses] in order to prevent those `NewBase` artifacts. I ran the full test suite with this modified version and it fully passed.
     3Unsure how to deal correctly with this. [https://bitbucket.org/gutworth/six/issue/66/replace-the-implementation-of I've proposed] `six` to replace their `with_metaclass` implementation with [https://github.com/mitsuhiko/flask/blob/6ec83e18dca497a8fbfca6caca5999984bd32f2e/flask/_compat.py#L56-L73 the one Flask uses] in order to prevent those `NewBase` artifacts. I ran the full Django test suite with this modified version and the `NewBase` hacks removed and it fully passed.
    44
    55Fixing the issue at this level makes more sense me than trying to work around it by `__mro__` and `__dict__` checks.
Back to Top