Add drag and drop ordering for inlines to set order_with_respect_to in admin interface

[anonymous]

Pre-MR, adding order_with_respect_to would present an ordering field in the admin interface (or a draggable list of inline objects if dom-drag.js was installed). Post M-R, neither appears. Not sure if this is a problem at the template level or at the model level.

[russell@…]

Hi,

The following patch works for me:

--- django/db/models/options.py (revision 3908)
+++ django/db/models/options.py (working copy)
@@ -2,7 +2,7 @@
 from django.db.models.related import RelatedObject
 from django.db.models.fields.related import ManyToManyRel
 from django.db.models.fields import AutoField, FieldDoesNotExist
-from django.db.models.loading import get_models
+from django.db.models.loading import get_models, get_apps, get_model
 from django.db.models.query import orderlist2sql
 from django.db.models import Manager
 from bisect import bisect
@@ -164,12 +164,12 @@
         "Returns a list of Options objects that are ordered with respect to this object."
         if not hasattr(self, '_ordered_objects'):
             objects = []
-            # TODO
-            #for klass in get_models(get_app(self.app_label)):
-            #    opts = klass._meta
-            #    if opts.order_with_respect_to and opts.order_with_respect_to.rel \
-            #        and self == opts.order_with_respect_to.rel.to._meta:
-            #        objects.append(opts)
+            for app in get_apps():
+                for model in get_models(app):
+                    opts = model._meta
+                    if opts.order_with_respect_to and opts.order_with_respect_to.rel \
+                        and self == opts.order_with_respect_to.rel.to._meta:
+                        objects.append(opts)
             self._ordered_objects = objects
         return self._ordered_objects

Just ... don't install dom-drag.js or the field will be greyed out :)

I'm working on re-implementing the drag-n-drop functionality[1] and will update this bug or file another when I've done that.

[1] ​http://groups.google.com/group/django-developers/browse_thread/thread/2af467c292b87067/0b64ccf351cf7542

Russell

[Russell Cloran <russell@…>]

I have a "working" patch for this. It uses dojo for the JavaScript, and only works for one related model. Oh, and only for edit_inline_tabular. ie, it's not ready for contribution by any means.

If you're interested in getting it anyways (there was some interest on the mailing list), please mail me directly.

[James Bennett]

Reassigning to xian since I know he's working on the JS stuff for newforms-admin.

[James Wheare]

Dupe of #13

[Mathijs de Bruin]

This is not merely a dup. of #2137, allthough it might be part of that one. Moreover, it has surely not been fixed.

[Mathijs de Bruin]

Updated patch for Django SVN r15376

[Simon Meers]

Is there an advantage in using nested get_app/get_models(app) rather than just using get_models()?

Also the _order field is marked as editable=False, so this in itself is insufficient for making it appear.