Changes between Version 1 and Version 2 of Ticket #20024, comment 10


Ignore:
Timestamp:
Aug 16, 2020, 11:07:50 AM (4 years ago)
Author:
Adam Sołtysik

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #20024, comment 10

    v1 v2  
    33As for `RelatedIn`, the things are weird here. It seems this case is handled differently and already works correctly, and worked even before #31667 (`test_ticket20024_related_in`). It was probably fixed in #13815 long ago. There is `IS NOT NULL` in the subquery, actually there are two next to each other. One is coming from `split_exclude()` (called in `build_filter()`), but the other one -- I couldn't find. Also, what looks like another thing to take a closer look at -- there is `NOT IN (None)` instead of `NOT IN (NULL)` in the SQL for the first query in that test, when the `rhs.discard(None)` line is removed.
    44
    5 Edit: I've moved the code to `build_filter()`, it fits better. New patch [https://github.com/adamsol/django/commit/abbbf5ba1a14d817ee74e753d0eeef60dab68285 here].
     5Edit: I've moved the code to `build_filter()`, it fits better. New patch [https://github.com/adamsol/django/commit/3ba23824c44911729a2c1ad7ff88ed73cc19767f here].
Back to Top