Changes between Initial Version and Version 1 of Ticket #18458, comment 2
- Timestamp:
- Oct 27, 2012, 9:35:00 AM (12 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #18458, comment 2
initial v1 1 1 I recently worked on this code and came to the conclusion that `get_expiry_age` and `get_expiry_date` are designed to work at the time when the session is saved, and not at any other point in time. 2 2 3 `get_expiry_age` i -used to determine the session cookie's maximum age. That probably explains the name. Since it's a public API, it's better to keep the current name, even if it isn't great.3 `get_expiry_age` is used to determine the session cookie's maximum age. That probably explains the name. Since it's a public API, it's better to keep the current name, even if it isn't great. 4 4 5 5 In order to fix #18194, I may have to introduced an optional parameter to pass the "reference time" (ie. the time the session was saved at); if not provided, this parameter would default to the current time. That would resolve this issue.