Changes between Version 1 and Version 2 of Ticket #18404, comment 6
- Timestamp:
- Nov 5, 2012, 6:23:09 PM (12 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #18404, comment 6
v1 v2 18 18 }}} 19 19 20 So this is definitly a bug. Most likely FileSystemStorage should accept only unicode locations and AppStaticStorage should pass a unicode path as done in the patch. It would also be good i s`path` didn't confuse `UnicodeDecodeError` with `ValueError` raised by `safe_join`. Maybe `safe_join` could raise a more meaningful subclass of `ValueError` instead?20 So this is definitly a bug. Most likely FileSystemStorage should accept only unicode locations and AppStaticStorage should pass a unicode path as done in the patch. It would also be good if `path` didn't confuse `UnicodeDecodeError` with `ValueError` raised by `safe_join`. Maybe `safe_join` could raise a more meaningful subclass of `ValueError` instead? 21 21 22 22 Note that on master (1.5) this will fail earlier (i.e. on every `os.path.join`), because of `unicode_literals` switch.