Opened 13 years ago

Closed 13 years ago

#17732 closed Uncategorized (fixed)

Add "ensure cookies are enabled" message to CSRF verification failed view

Reported by: h3 Owned by: nobody
Component: Uncategorized Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This is a follow up ticket for this discussion:

http://groups.google.com/group/django-developers/browse_thread/thread/ca34924871e3c00b/b29cd0e17c010f54?lnk=gst&q=csrf+cookie+haineault#b29cd0e17c010f54

Sorry for the late response .. been quite busy.

Patch is include, with bonus screenshot: http://i.imgur.com/dyYSm.png

Attachments (2)

django-csrf-missing-help-cookies.patch (503 bytes ) - added by h3 13 years ago.
django-csrf-missing-help-cookies-view.patch (664 bytes ) - added by h3 13 years ago.
Patch of the csrf view to serve the correct reason

Download all attachments as: .zip

Change History (4)

by h3, 13 years ago

Patch of the csrf view to serve the correct reason

comment:1 by Paul McMillan, 13 years ago

I'd like to get these fixed, but your provided patch doesn't even pass the existing test suite... I did commit the additional error message.

Version 1, edited 13 years ago by Paul McMillan (previous) (next) (diff)

comment:2 by Paul McMillan, 13 years ago

Resolution: fixed
Status: newclosed
Triage Stage: UnreviewedAccepted

I'm going to go ahead and close this ticket, since I've committed the part which can be committed. If you have a way to improve the error message without tying to the session framework, and without changing the existing behavior, please feel free to re-open the ticket with a patch, or discuss it on the mailing list.

Note: See TracTickets for help on using tickets.
Back to Top