Changes between Initial Version and Version 1 of Ticket #17717, comment 8


Ignore:
Timestamp:
Mar 3, 2012, 2:50:35 PM (13 years ago)
Author:
Anssi Kääriäinen

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17717, comment 8

    initial v1  
    1 Yes, that should be fixed. Now proxy_for_model is the actual proxied model, so as written the patch isn't correct any more. That is my failing, as I should have written it using the while {{{ opts._proxy_for_model: opts = opts._proxy_for_model._meta }}} idiom instead of assuming the buggy behavior in the patch.
     1Yes, that should be fixed. Now proxy_for_model is the actual proxied model, so as written the committed patch isn't correct any more. That is my failing, as I should have written it using the while {{{ opts._proxy_for_model: opts = opts._proxy_for_model._meta }}} idiom instead of assuming the buggy behavior in the patch.
    22
    33I tested the patch and without the fix it fails, with the fix in the patch it succeeds. I quickly skimmed through it and it seems ready for checkin to me.
Back to Top