Changes between Initial Version and Version 1 of Ticket #17688, comment 19


Ignore:
Timestamp:
Feb 28, 2024, 4:32:09 PM (9 months ago)
Author:
Gary Chen

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17688, comment 19

    initial v1  
    1 Interested in taking on this change. I'm thinking it'll involve:
    2 * Undoing [26c4be2ebe] to disable fast_deletes when m2m_changed signals are connected
    3 * Took at look at [https://github.com/django/django/pull/6579] but I'm not sure the approach there is correct, the hidden through model is already included and cascaded in the collector. We just need to fire the correct signal in that case, and we can do so easily by checking `model._meta.auto_created`  [https://github.com/django/django/blob/a97d6b198eec13a98ef60d7f440528ba82889071/django/db/models/deletion.py#L327 which is already being done].
     1Interested in taking on this change. I'm thinking it'll involve undoing [26c4be2ebe] to disable fast_deletes when m2m_changed signals are connected on top of [https://github.com/django/django/pull/6579].
    42
    53One question is if `model._meta.auto_created` is indeed a determiner for if a model is a generated m2m through model--I'm assuming it's already being used as such to skip pre/post_delete signals.
Back to Top