Changes between Initial Version and Version 1 of Ticket #15145, comment 2


Ignore:
Timestamp:
Feb 26, 2011, 6:30:44 PM (14 years ago)
Author:
Sam Thompson

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #15145, comment 2

    initial v1  
    33One possible source of the problem is in {{{WhereNode.make_atom()}}}.  When called on an {{{in}}} lookup with an empty list, it raises an {{{EmptyResultSet}}} which drops it from the query entirely.  It should first check to see if it is part of an exclude, but I'm not sure that information is available at that point.
    44
    5 This should either be a wontfix (check your list before excluding on it), or a not-small refactor of the make_atom/as_sql portion of WhereNode to pass state into inner nodes of the tree.
     5This should either be a wontfix (check your list before excluding on it), or a not-small refactor of the make_atom/as_sql portion of {{{WhereNode}}} to pass state into inner nodes of the tree.
    66
    77I'll upload a non-solution patch to illustrate the problem.  This breaks one other test, of course:  {{{aggregation_regress.AggregationTests.test_empty_filter_aggregate}}}
Back to Top