Opened 16 years ago

Last modified 13 years ago

#10372 closed

get_svn_revision() should be more robust — at Version 4

Reported by: rjaarts Owned by: Matt Boersma
Component: Core (Other) Version: 1.0
Severity: Keywords: version Google App Engine GAE
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Matt Boersma)

When Django is used in the Google App Engine (GAE)environment there is a problem with the django get_svn_revision() function. This occurs only in when using the GAE SDK and when a checked out version of Django is used.
The get_svn_revision() function checks for existence of a ".svn/entries" file. This file will exist if Django was checked out, but GAE will prevent reading that file, which results in an raised error. Would be nice if this error could be catched, and perhaps a warning logged, and simple "unknown" would be returned.

Change History (5)

comment:1 by Alex Gaynor, 16 years ago

milestone: 1.1 beta1.1

This isn't a feature and thus isn't for the 1.1 beta.

comment:2 by Jacob, 16 years ago

Triage Stage: UnreviewedAccepted

comment:3 by Matt Boersma, 16 years ago

Owner: changed from nobody to Matt Boersma
Status: newassigned

comment:4 by Matt Boersma, 16 years ago

Description: modified (diff)
Has patch: set
Summary: get_svn_version() should be more robustget_svn_revision() should be more robust

by Matt Boersma, 16 years ago

Attachment: 10372.diff added
Note: See TracTickets for help on using tickets.
Back to Top