Ticket #8528: ticket8528-nullfilter-1-1-1-final.diff

django/contrib/admin/filterspecs.py

@@ -61 +61 @@
             self.lookup_title = f.verbose_name
         rel_name = f.rel.to._meta.pk.name
         self.lookup_kwarg = '%s__%s__exact' % (self.field_path, rel_name)
+        self.lookup_null_kwarg = '%s__isnull' % (f.name)
         self.lookup_val = request.GET.get(self.lookup_kwarg, None)
+        self.lookup_null = request.GET.get(self.lookup_null_kwarg, None)
         self.lookup_choices = f.get_choices(include_blank=False)
 
     def has_output(self):
@@ -71 +73 @@
         return self.lookup_title
 
     def choices(self, cl):
-        yield {'selected': self.lookup_val is None,
-               'query_string': cl.get_query_string({}, [self.lookup_kwarg]),
+        yield {'selected': self.lookup_val is None and not self.lookup_null,
+               'query_string': cl.get_query_string({}, [self.lookup_kwarg, self.lookup_null_kwarg]),
                'display': _('All')}
         for pk_val, val in self.lookup_choices:
             yield {'selected': self.lookup_val == smart_unicode(pk_val),
-                   'query_string': cl.get_query_string({self.lookup_kwarg: pk_val}),
+                   'query_string': cl.get_query_string({self.lookup_kwarg: pk_val}, [self.lookup_null_kwarg]),
                    'display': val}
+        if self.field.null:
+            yield {'selected': self.lookup_null,
+                   'query_string': cl.get_query_string({self.lookup_null_kwarg: 'True'}, [self.lookup_kwarg]),
+                   'display': '(%s)' % _("None")}
 
 FilterSpec.register(lambda f: bool(f.rel), RelatedFilterSpec)
 
@@ -163 +169 @@
     def __init__(self, f, request, params, model, model_admin, field_path=None):
         super(AllValuesFilterSpec, self).__init__(f, request, params, model, model_admin, field_path=field_path)
         self.lookup_val = request.GET.get(self.field_path, None)
-        #self.lookup_choices = model_admin.queryset(request).distinct().order_by(f.name).values(f.name)
+        self.lookup_null = request.GET.get(f.name + '__isnull', None)
         self.lookup_choices = model._default_manager.all().distinct().order_by(f.name).values(f.name)
 
     def title(self):
         return self.field.verbose_name
 
     def choices(self, cl):
-        yield {'selected': self.lookup_val is None,
-               'query_string': cl.get_query_string({}, [self.field_path]),
+        yield {'selected': self.lookup_val is None and not self.lookup_null,
+               'query_string': cl.get_query_string({}, [self.field.name, self.field_path + '__isnull']),
                'display': _('All')}
         for val in self.lookup_choices:
-            val = smart_unicode(val[self.field.name])
-            yield {'selected': self.lookup_val == val,
-                   'query_string': cl.get_query_string({self.field_path: val}),
-                   'display': val}
-FilterSpec.register(lambda f: True, AllValuesFilterSpec)
+            if val[self.field_path] is None:
+                yield {'selected': self.lookup_null,
+                       'query_string': cl.get_query_string({self.field_path + '__isnull': 'True'}, [self.field_path]),
+                       'display': '(%s)' % _("None")}
+            else:
+                val = smart_unicode(val[self.field_path])
+                yield {'selected': self.lookup_val == val,
+                       'query_string': cl.get_query_string({self.field_path: val}, [self.field_path + '__isnull']),
+                       'display': val}
+FilterSpec.register(lambda f: True, AllValuesFilterSpec)