Ticket #34424: diff.patch

django/forms/widgets.py

@@ -1161 +1161 @@
                 # Return pseudo-ISO dates with zeros for any unselected values,
                 # e.g. '2017-0-23'.
                 return "%s-%s-%s" % (y or 0, m or 0, d or 0)
+            except OverflowError:
+                return '0-0-0'
             return date_value.strftime(input_format)
         return data.get(name)
 

tests/forms_tests/field_tests/test_datefield.py

@@ +1 @@
+import sys
 from datetime import date, datetime
 
 from django.core.exceptions import ValidationError
@@ -32 +33 @@
         self.assertFalse(c.is_valid())
         self.assertEqual(c.errors, {"mydate": ["Enter a valid date."]})
 
+        # Would trigger an "OverflowError: Python int too large to convert to C long".
+        c = GetDate({"mydate_month": str(sys.maxsize+1), "mydate_day": "31", "mydate_year": "2010"})
+        self.assertFalse(c.is_valid())
+        self.assertEqual(c.errors, {"mydate": ["Enter a valid date."]})
+
         # label tag is correctly associated with month dropdown
         d = GetDate({"mydate_month": "1", "mydate_day": "1", "mydate_year": "2010"})
         self.assertIn('<label for="id_mydate_month">', d.as_p())
@@ -149 +155 @@
             f.clean("200a-10-25")
         with self.assertRaisesMessage(ValidationError, "'Enter a valid date.'"):
             f.clean("25/10/06")
+        with self.assertRaisesMessage(ValidationError, "'Enter a valid date.'"):
+            f.clean("0-0-0")
         with self.assertRaisesMessage(ValidationError, "'This field is required.'"):
             f.clean(None)
 

tests/forms_tests/widget_tests/test_selectdatewidget.py

@@ +1 @@
+import sys
 from datetime import date
 
 from django.forms import DateField, Form, SelectDateWidget
@@ -610 +611 @@
             ((None, "12", "1"), None),
             (("2000", None, "1"), None),
             (("2000", "12", None), None),
+            ((str(sys.maxsize+1), "12", "1"), "0-0-0"),
         ]
         for values, expected in tests:
             with self.subTest(values=values):