Ticket #2445: choices_func_newforms-admin.patch

django/db/models/base.py

@@ -165 +165 @@
                 val = field.get_default()
             setattr(self, field.attname, val)
 
+        for item in dir(self):
+            if item.startswith('choices_for__'):
+                choice_func = getattr(self,item)
+                if callable(choice_func):
+                    field_name = choice_func.__name__[len('choices_for__'):]
+                    self._meta.get_field(field_name)._choices = choice_func
+        
         if kwargs:
             for prop in kwargs.keys():
                 try:

django/db/models/fields/__init__.py

@@ -8 +8 @@
 
 from django.db import get_creation_module
 from django.db.models import signals
+import django.db.models.query
 from django.dispatch import dispatcher
 from django.conf import settings
 from django.core import validators
@@ -338 +339 @@
         "Returns a list of tuples used as SelectField choices for this field."
         first_choice = include_blank and blank_choice or []
         if self.choices:
-            return first_choice + list(self.choices)
+            if callable(self.choices):
+                choices = self.choices()
+            else:
+                choices = self.choices
+            # If choices is a QuerySet, convert into a tuple list ((pk,__unicode__),etc)
+            if isinstance(choices, django.db.models.query.QuerySet):
+                choices = [(x._get_pk_val(), smart_unicode(x)) for x in choices]
+            return first_choice + list(choices)
+            
         rel_model = self.rel.to
         if hasattr(self.rel, 'get_related_field'):
             lst = [(getattr(x, self.rel.get_related_field().attname), smart_unicode(x)) for x in rel_model._default_manager.complex_filter(self.rel.limit_choices_to)]
@@ -391 +400 @@
         defaults = {'required': not self.blank, 'label': capfirst(self.verbose_name), 'help_text': self.help_text}
         if self.choices:
             defaults['widget'] = forms.Select(choices=self.get_choices(include_blank=self.blank or not (self.has_default() or 'initial' in kwargs)))
+            kwargs['queryset'] = self.choices()
         if self.has_default():
             defaults['initial'] = self.get_default()
         defaults.update(kwargs)