Ticket #18751: ticket-18751.0.diff

File ticket-18751.0.diff, 981 bytes (added by Simon Charette, 12 years ago)
  • django/forms/formsets.py

    diff --git a/django/forms/formsets.py b/django/forms/formsets.py
    index 4ea8dc4..058a086 100644
    a b class BaseFormSet(StrAndUnicode):  
    252252    errors = property(_get_errors)
    253253
    254254    def _should_delete_form(self, form):
    255         # The way we lookup the value of the deletion field here takes
    256         # more code than we'd like, but the form's cleaned_data will
    257         # not exist if the form is invalid.
    258         field = form.fields[DELETION_FIELD_NAME]
    259         raw_value = form._raw_value(DELETION_FIELD_NAME)
    260         should_delete = field.clean(raw_value)
    261         return should_delete
     255        """
     256        Returns wether or not the form was marked for deletion
     257        """
     258        # Make sure to trigger form validation in order to populate
     259        # cleaned data.
     260        form.is_valid()
     261        return form.cleaned_data.get(DELETION_FIELD_NAME, False)
    262262
    263263    def is_valid(self):
    264264        """
Back to Top