Ticket #18094: failing-testcase.diff

tests/regressiontests/delete_regress/models.py

@@ -68 +68 @@
     version = models.ForeignKey(Version)
     location = models.ForeignKey(Location, blank=True, null=True)
 
-# Models for #16128
+# Models for #16128 and #18094
 
 class File(models.Model):
     pass
@@ -93 +93 @@
 class FooFileProxy(FooFile):
     class Meta:
         proxy = True
+        
+class BarFile(File):
+    pass
+
+class BarFileProxy1(BarFile):
+    class Meta:
+        proxy = True
+        
+class BarFileProxy1Proxy(BarFileProxy1):
+    class Meta:
+        proxy = True
+        
+class BarFileProxy2(BarFile):
+    class Meta:
+        proxy = True
+

tests/regressiontests/delete_regress/tests.py

@@ -3 +3 @@
 import datetime
 
 from django.conf import settings
-from django.db import backend, transaction, DEFAULT_DB_ALIAS
+from django.db import backend, models, transaction, DEFAULT_DB_ALIAS
 from django.test import TestCase, TransactionTestCase, skipUnlessDBFeature
 
 from .models import (Book, Award, AwardNote, Person, Child, Toy, PlayedWith,
     PlayedWithNote, Email, Researcher, Food, Eaten, Policy, Version, Location,
-    Item, Image, File, Photo, FooFile, FooImage, FooPhoto, FooFileProxy)
+    Item, Image, File, Photo, FooFile, FooImage, FooPhoto, FooFileProxy,
+    BarFile, BarFileProxy1, BarFileProxy1Proxy, BarFileProxy2)
 
 
 # Can't run this test under SQLite, because you can't
@@ -258 +259 @@
         Image.objects.all().delete()
 
         self.assertEqual(len(FooFileProxy.objects.all()), 0)
+
+class DeletionSignalsTest(TestCase):
+    """
+    Deletion signals should be sent correctly in inheritance scenarios 
+    involving proxies (as described in #18094).
+    
+    """
+    
+    senders = (File, Image, Photo,
+               BarFile, BarFileProxy1, BarFileProxy1Proxy, BarFileProxy2)
+    
+    def setUp(self):
+        self.clear_received_senders()
+        for sender in self.senders:
+            models.signals.pre_delete.connect(self.pre_delete_receiver, sender)
+            models.signals.post_delete.connect(self.post_delete_receiver, sender)
+        
+    def tearDown(self):
+        for sender in self.senders:
+            models.signals.pre_delete.disconnect(self.pre_delete_receiver, sender)
+            models.signals.post_delete.disconnect(self.post_delete_receiver, sender)
+      
+    def clear_received_senders(self):
+        self.pre_delete_senders = []
+        self.post_delete_senders = []
+            
+    def pre_delete_receiver(self, sender, **kwargs):
+        self.pre_delete_senders.append(sender)
+        
+    def post_delete_receiver(self, sender, **kwargs):
+        self.post_delete_senders.append(sender)
+        
+    def test_simple_proxy_deletion(self):
+        """
+        Triggering deletion from a concrete model instance should send the same
+        signals as an instance of a proxy of this model. Signals should be
+        orderly sent for all proxies of the deleted concrete model (based on
+        their inheritance depth and declaration order) and finally for the
+        concrete model itself.
+        
+        """
+        expected_senders = [Photo, Image, File]
+        
+        File.objects.create().delete()
+        self.assertEqual(self.pre_delete_senders, expected_senders)
+        self.assertEqual(self.post_delete_senders, expected_senders)
+        
+        self.clear_received_senders()
+        
+        Image.objects.create().delete()
+        self.assertEqual(self.pre_delete_senders, expected_senders)
+        self.assertEqual(self.post_delete_senders, expected_senders)
+        
+        self.clear_received_senders()
+        
+        Photo.objects.create().delete()
+        self.assertEqual(self.pre_delete_senders, expected_senders)
+        self.assertEqual(self.post_delete_senders, expected_senders)
+
+    def test_multi_table_inheritance_proxy_deletion(self):
+        """
+        In a multi-table inheritance scenario, deletion signals should also be
+        orderly sent for all proxies of concrete model involved in the deletion.
+        
+        """
+        expected_senders = [BarFileProxy1Proxy, BarFileProxy1, BarFileProxy2,
+                            BarFile, Photo, Image, File]
+    
+        BarFile.objects.create().delete()
+        self.assertEqual(self.pre_delete_senders, expected_senders)
+        self.assertEqual(self.post_delete_senders, expected_senders)
+        
+        self.clear_received_senders()
+        
+        BarFileProxy1.objects.create().delete()
+        self.assertEqual(self.pre_delete_senders, expected_senders)
+        self.assertEqual(self.post_delete_senders, expected_senders)
+        
+        self.clear_received_senders()
+        
+        BarFileProxy2.objects.create().delete()
+        self.assertEqual(self.pre_delete_senders, expected_senders)
+        self.assertEqual(self.post_delete_senders, expected_senders)
+        
+        self.clear_received_senders()
+        
+        BarFileProxy1Proxy.objects.create().delete()
+        self.assertEqual(self.pre_delete_senders, expected_senders)
+        self.assertEqual(self.post_delete_senders, expected_senders)