Ticket #17944: ReadOnlyPasswordHashWidget_0.1.patch

django/contrib/auth/tests/forms.py

@@ -236 +236 @@
         # Just check we can create it
         form = MyUserForm({})
 
+    def test_bug_17944_empty_password(self):
+        # Unable to access to User record in the admin if the user has a unmanageable password
+        user = User.objects.get(username='empty_password')
+        form = UserChangeForm(instance=user)
+        # just check no error is raised
+        form.as_table()
+
+    def test_bug_17944_unmanageable_password(self):
+        # Unable to access to User record in the admin if the user has a unmanageable password
+        user = User.objects.get(username='unmanageable_password')
+        form = UserChangeForm(instance=user)
+        #just check no error is raised
+        form.as_table()
+
+
 UserChangeFormTest = override_settings(USE_TZ=False)(UserChangeFormTest)
 
 

django/contrib/auth/fixtures/authtestdata.json

@@ -52 +52 @@
             "email": "staffmember@example.com", 
             "date_joined": "2006-12-17 07:03:31"
         }
+    },
+    {
+        "pk": "4",
+        "model": "auth.user",
+        "fields": {
+            "username": "empty_password",
+            "first_name": "Empty",
+            "last_name": "Password",
+            "is_active": true,
+            "is_superuser": false,
+            "is_staff": true,
+            "last_login": "2006-12-17 07:03:31",
+            "groups": [],
+            "user_permissions": [],
+            "password": "",
+            "email": "empty_password@example.com",
+            "date_joined": "2006-12-17 07:03:31"
+        }
+    },
+    {
+        "pk": "5",
+        "model": "auth.user",
+        "fields": {
+            "username": "unmanageable_password",
+            "first_name": "Unmanageable",
+            "last_name": "Password",
+            "is_active": true,
+            "is_superuser": false,
+            "is_staff": true,
+            "last_login": "2006-12-17 07:03:31",
+            "groups": [],
+            "user_permissions": [],
+            "password": "$",
+            "email": "unmanageable_password@example.com",
+            "date_joined": "2006-12-17 07:03:31"
+        }
     }
 ]

django/contrib/auth/forms.py

@@ -28 +28 @@
 
         encoded = smart_str(encoded)
 
-        if len(encoded) == 32 and '$' not in encoded:
-            hasher = get_hasher('unsalted_md5')
+        try:
+            if len(encoded) == 32 and '$' not in encoded:
+                hasher = get_hasher('unsalted_md5')
+            else:
+                algorithm = encoded.split('$', 1)[0]
+                hasher = get_hasher(algorithm)
+        except ValueError:
+            summary = "<strong>%s</strong>" % ugettext('Unknown password hashing algorithm')
         else:
-            algorithm = encoded.split('$', 1)[0]
-            hasher = get_hasher(algorithm)
+            summary = ""
+            for key, value in hasher.safe_summary(encoded).iteritems():
+                summary += "<strong>%(key)s</strong>: %(value)s " % {"key": ugettext(key), "value": value}
 
-        summary = ""
-        for key, value in hasher.safe_summary(encoded).iteritems():
-            summary += "<strong>%(key)s</strong>: %(value)s " % {"key": ugettext(key), "value": value}
-
         return mark_safe("<div%(attrs)s>%(summary)s</div>" % {"attrs": flatatt(final_attrs), "summary": summary})