Ticket #17615: unique_field_with_mti.diff

django/db/models/base.py

@@ -724 +724 @@
             # Exclude the current object from the query if we are editing an
             # instance (as opposed to creating a new one)
             if not self._state.adding and self.pk is not None:
-                qs = qs.exclude(pk=self.pk)
+                if model_class is self.__class__:
+                    pk = self.pk
+                else:
+                    pk = getattr(self, self._meta.get_ancestor_link(model_class).attname)
+                qs = qs.exclude(pk=pk)
 
             if qs.exists():
                 if len(unique_check) == 1:

tests/regressiontests/model_inheritance_regress/models.py

@@ -163 +163 @@
 
 class TrainStation(Station):
     zone = models.IntegerField()
+
+class User(models.Model):
+    username = models.CharField(max_length=30, unique=True)
+
+class Profile(User):
+    profile_id = models.AutoField(primary_key=True)
+    extra = models.CharField(max_length=30, blank=True)

tests/regressiontests/model_inheritance_regress/tests.py

@@ -4 +4 @@
 
 import datetime
 from operator import attrgetter
+from django import forms
 
 from django.test import TestCase
 
@@ -11 +12 @@
     ParkingLot2, ParkingLot3, Supplier, Wholesaler, Child, SelfRefParent,
     SelfRefChild, ArticleWithAuthor, M2MChild, QualityControl, DerivedM,
     Person, BirthdayParty, BachelorParty, MessyBachelorParty,
-    InternalCertificationAudit, BusStation, TrainStation)
+    InternalCertificationAudit, BusStation, TrainStation, User, Profile)
+
+
+class ProfileForm(forms.ModelForm):
+    class Meta:
+        model = Profile
 
 
 class ModelInheritanceTest(TestCase):
@@ -406 +412 @@
         )
         self.assertIs(BusStation._meta.pk.model, BusStation)
         self.assertIs(TrainStation._meta.pk.model, TrainStation)
+
+    def test_inherited_unique_field_with_form(self):
+        User.objects.create(username="user_only")
+        p = Profile.objects.create(username="user_with_profile")
+        form = ProfileForm({'username': "user_with_profile", 'extra': "hello"}, instance=p)
+        self.assertTrue(form.is_valid())