Context Navigation

Ticket #16533: float-cache-timeout.diff

File float-cache-timeout.diff, 1.4 KB (added by Jeff Balogh, 13 years ago)
Force timeouts to be ints in get_memcache_timeout

diff --git a/django/core/cache/backends/memcached.py b/django/core/cache/backends/memcached.py
index e452498..e32fce9 100644

                class BaseMemcachedCache(BaseCache):
+            #
             # This means that we have to switch to absolute timestamps.
             timeout += int(time.time())
         return timeout
+        return int(timeout)
     def add(self, key, value, timeout=0, version=None):
         key = self.make_key(key, version=version)

diff --git a/tests/regressiontests/cache/tests.py b/tests/regressiontests/cache/tests.py
index c5349d5..1ab5286 100644

                class BaseCacheTests(object):
         self.assertEqual(self.cache.get('key3'), 'sausage')
         self.assertEqual(self.cache.get('key4'), 'lobster bisque')
+    def test_float_timeout(self):
+        # Make sure a timeout given as a float doesn't crash anything.
+        self.cache.set("key1", "spam", 100.2)
+        self.assertEqual(self.cache.get("key1"), "spam")
     def perform_cull_test(self, initial_count, final_count):
         """This is implemented as a utility method, because only some of the backends
         implement culling. The culling algorithm also varies slightly, so the final