Ticket #16182: 16182-increased-signing-precision-3.diff

django/core/signing.py

@@ -158 +158 @@
 
 
 class TimestampSigner(Signer):
+    def __init__(self, *args, **kwargs):
+        self.time_func = kwargs.pop('time', time.time)
+        super(TimestampSigner, self).__init__(*args, **kwargs)
+    
     def timestamp(self):
-        return baseconv.base62.encode(int(time.time()))
+        return baseconv.base62.encode(int(self.time_func() * 10000))
 
     def sign(self, value):
         value = smart_str('%s%s%s' % (value, self.sep, self.timestamp()))
@@ -168 +172 @@
     def unsign(self, value, max_age=None):
         result =  super(TimestampSigner, self).unsign(value)
         value, timestamp = result.rsplit(self.sep, 1)
-        timestamp = baseconv.base62.decode(timestamp)
+        timestamp = baseconv.base62.decode(timestamp) / 10000.0
         if max_age is not None:
             # Check timestamp is not older than max_age
-            age = time.time() - timestamp
+            age = self.time_func() - timestamp
             if age > max_age:
                 raise SignatureExpired(
                     'Signature age %s > %s seconds' % (age, max_age))

tests/regressiontests/signing/tests.py

@@ -98 +98 @@
 
     def test_timestamp_signer(self):
         value = u'hello'
-        _time = time.time
-        time.time = lambda: 123456789
-        try:
-            signer = signing.TimestampSigner('predictable-key')
-            ts = signer.sign(value)
-            self.assertNotEqual(ts,
-                signing.Signer('predictable-key').sign(value))
+        signer = signing.TimestampSigner('predictable-key',
+            time=lambda: 123456789)
+        ts = signer.sign(value)
+        self.assertNotEqual(ts,
+            signing.Signer('predictable-key').sign(value))
 
-            self.assertEqual(signer.unsign(ts), value)
-            time.time = lambda: 123456800
-            self.assertEqual(signer.unsign(ts, max_age=12), value)
-            self.assertEqual(signer.unsign(ts, max_age=11), value)
-            self.assertRaises(
-                signing.SignatureExpired, signer.unsign, ts, max_age=10)
-        finally:
-            time.time = _time
+        self.assertEqual(signer.unsign(ts), value)
+        signer = signing.TimestampSigner('predictable-key',
+            time=lambda: 123456800)
+        self.assertEqual(signer.unsign(ts, max_age=12), value)
+        self.assertEqual(signer.unsign(ts, max_age=11), value)
+        self.assertRaises(
+            signing.SignatureExpired, signer.unsign, ts, max_age=10)
+    
+    def test_timestamp_precision(self):
+        one = signing.TimestampSigner('key', time=lambda: 123.4567).sign('v')
+        two = signing.TimestampSigner('key', time=lambda: 123.4568).sign('v')
+        self.assertNotEqual(one, two)