Ticket #16137: get_or_create_no_kwargs.diff

django/db/models/query.py

@@ -358 +358 @@
         Returns a tuple of (object, created), where created is a boolean
         specifying whether an object was created.
         """
-        assert kwargs, \
-                'get_or_create() must be passed at least one keyword argument'
         defaults = kwargs.pop('defaults', {})
         lookup = kwargs.copy()
         for f in self.model._meta.fields:

tests/modeltests/get_or_create/models.py

@@ -16 +16 @@
     def __unicode__(self):
         return u'%s %s' % (self.first_name, self.last_name)
 
+class DefaultPerson(models.Model):
+    first_name = models.CharField(max_length=100, default="Anonymous")
+
 class ManualPrimaryKeyTest(models.Model):
     id = models.IntegerField(primary_key=True)
     data = models.CharField(max_length=100)

tests/modeltests/get_or_create/tests.py

@@ -3 +3 @@
 from django.db import IntegrityError
 from django.test import TestCase
 
-from models import Person, ManualPrimaryKeyTest
+from models import Person, DefaultPerson, ManualPrimaryKeyTest
 
 
 class GetOrCreateTests(TestCase):
@@ -50 +50 @@
             ManualPrimaryKeyTest.objects.get_or_create, id=1, data="Different"
         )
         self.assertEqual(ManualPrimaryKeyTest.objects.get(id=1).data, "Original")
+
+    def test_get_or_create_empty(self):
+        # If all the attributes on a model have defaults, we shouldn't
+        # need to pass any arguments.
+        try:
+            DefaultPerson.objects.get_or_create()
+        except AssertionError:
+            self.assertTrue(False)