Ticket #14742: select_across.patch

options.py

@@ -736 +736 @@
             select_across = action_form.cleaned_data['select_across']
             func, name, description = self.get_actions(request)[action]
 
+            # Allow each action to choose if it requires selections, or will
+            # operate on all matching records by default
+            if select_across is None:
+                select_across = getattr(func, 'select_across', False)
+
             # Get the list of selected PKs. If nothing's selected, we can't
             # perform an action on it, so bail. Except we want to perform
             # the action explicitly on all objects.
@@ -992 +997 @@
         # Actions with no confirmation
         if (actions and request.method == 'POST' and
                 'index' in request.POST and '_save' not in request.POST):
-            if selected:
-                response = self.response_action(request, queryset=cl.get_query_set())
-                if response:
-                    return response
-                else:
-                    action_failed = True
+            response = self.response_action(request, queryset=cl.get_query_set())
+            if response:
+                return response
             else:
-                msg = _("Items must be selected in order to perform "
-                        "actions on them. No items have been changed.")
-                self.message_user(request, msg)
                 action_failed = True
 
         # Actions with confirmation

helpers.py

@@ -17 +17 @@
 
 class ActionForm(forms.Form):
     action = forms.ChoiceField(label=_('Action:'))
-    select_across = forms.BooleanField(label='', required=False, initial=0,
+    select_across = forms.NullBooleanField(label='', required=False, initial=None,
         widget=forms.HiddenInput({'class': 'select-across'}))
 
 checkbox = forms.CheckboxInput({'class': 'action-select'}, lambda value: False)